linux-kernel - Re: [PATCH 10/14] staging/lustre/llite: protect from accessing NULL lli

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611070155310.21293@casper.infradead.org>
Date:   Mon, 7 Nov 2016 01:55:44 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Oleg Drokin <green@...uxhacker.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        Bobi Jam <bobijam.xu@...el.com>
Subject: Re: [PATCH 10/14] staging/lustre/llite: protect from accessing NULL
 lli_clob


> From: Bobi Jam <bobijam.xu@...el.com>
> 
> Need to check file's lli_clob object before calling
> lov_read_and_clear_async_rc().

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: Bobi Jam <bobijam.xu@...el.com>
> Reviewed-by: Jinshan Xiong <jinshan.xiong@...el.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@...el.com>
> Reviewed-on: http://review.whamcloud.com/23031
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8682
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/staging/lustre/lustre/llite/file.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index c1c7551..7886840 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -2328,9 +2328,11 @@ int ll_fsync(struct file *file, loff_t start, loff_t end, int datasync)
>  		lli->lli_async_rc = 0;
>  		if (rc == 0)
>  			rc = err;
> -		err = lov_read_and_clear_async_rc(lli->lli_clob);
> -		if (rc == 0)
> -			rc = err;
> +		if (lli->lli_clob) {
> +			err = lov_read_and_clear_async_rc(lli->lli_clob);
> +			if (rc == 0)
> +				rc = err;
> +		}
>  	}
>  
>  	err = md_sync(ll_i2sbi(inode)->ll_md_exp, ll_inode2fid(inode), &req);
> -- 
> 2.7.4
> 
>