linux-kernel - Re: [PATCH 09/14] staging/lustre/ptlrpc: Suppress error for flock requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611070157110.21293@casper.infradead.org>
Date:   Mon, 7 Nov 2016 01:57:21 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Oleg Drokin <green@...uxhacker.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        Patrick Farrell <paf@...y.com>
Subject: Re: [PATCH 09/14] staging/lustre/ptlrpc: Suppress error for flock
 requests


> From: Patrick Farrell <paf@...y.com>
> 
> -EAGAIN is a normal return when requesting POSIX flocks.
> We can't recognize exactly that case here, but it's the
> only case that should result in -EAGAIN on LDLM_ENQUEUE, so
> don't print to console in that case.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: Patrick Farrell <paf@...y.com>
> Reviewed-on: http://review.whamcloud.com/22856
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8658
> Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>
> Reviewed-by: Bob Glossman <bob.glossman@...el.com>
> Signed-off-by: Oleg Drokin <green@...uxhacker.ru>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/client.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index 7cbfb4c..bb7ae4e 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/client.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
> @@ -1191,7 +1191,9 @@ static int ptlrpc_check_status(struct ptlrpc_request *req)
>  		lnet_nid_t nid = imp->imp_connection->c_peer.nid;
>  		__u32 opc = lustre_msg_get_opc(req->rq_reqmsg);
>  
> -		if (ptlrpc_console_allow(req))
> +		/* -EAGAIN is normal when using POSIX flocks */
> +		if (ptlrpc_console_allow(req) &&
> +		    !(opc == LDLM_ENQUEUE && err == -EAGAIN))
>  			LCONSOLE_ERROR_MSG(0x011, "%s: operation %s to node %s failed: rc = %d\n",
>  					   imp->imp_obd->obd_name,
>  					   ll_opcode2str(opc),
> -- 
> 2.7.4
> 
>