linux-kernel - Re: [PATCH v2] staging: lustre: fixed shadowed variable in socklnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611070200570.21293@casper.infradead.org>
Date:   Mon, 7 Nov 2016 02:01:11 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Andrew Kanner <andrew.kanner@...il.com>
cc:     oleg.drokin@...el.com, andreas.dilger@...el.com,
        gregkh@...uxfoundation.org, viro@...iv.linux.org.uk,
        bevans@...y.com, bhaktipriya96@...il.com,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: lustre: fixed shadowed variable in
 socklnd_cb.c


> Removed redundant declaration of variable 'tx' in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Signed-off-by: Andrew Kanner <andrew.kanner@...il.com>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
> index c1c6f60..f31f4a1 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
> @@ -2473,8 +2473,8 @@ ksocknal_check_peer_timeouts(int idx)
>  		 * holding only shared lock
>  		 */
>  		if (!list_empty(&peer->ksnp_tx_queue)) {
> -			struct ksock_tx *tx = list_entry(peer->ksnp_tx_queue.next,
> -						    struct ksock_tx, tx_list);
> +			tx = list_entry(peer->ksnp_tx_queue.next,
> +					struct ksock_tx, tx_list);
>  
>  			if (cfs_time_aftereq(cfs_time_current(),
>  					     tx->tx_deadline)) {
> -- 
> 2.1.4
> 
>