linux-kernel - Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 07 Nov 2016 15:55:08 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Cc:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "vireshk@...nel.org" <vireshk@...nel.org>,
        "vinod.koul@...el.com" <vinod.koul@...el.com>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware
 properties

On Wed, 2016-11-02 at 11:55 +0000, Eugeniy Paltsev wrote:
> Hi Andy,
> Could you possibly tell me your ideas about these changes?
> Thanks.

Thanks for an update, but, please, answer to all my comments to your
patch v2. Either you are okay with them, then you didn't address few, or
you are not okay, I didn't get why. Deffer newer version until we get an
agreement on the implementation.

> 
> On Fri, 2016-10-28 at 18:59 +0300, Eugeniy Paltsev wrote:
> > This series is to address a proposal by Andy in these threads:
> > http://www.spinics.net/lists/dmaengine/msg11506.html
> > http://www.spinics.net/lists/dmaengine/msg11541.html
> > Split platform data to actual hardware properties, and platform
> > quirks.
> > Now we able to use quirks and hardware properties separately from
> > different sources (pdata, device tree or autoconfig registers)
> > 
> > Changes for v3:
> >  -   Split changes to separate patches.
> >  -   Add "DW_DMA_IS_LLP_SUPPORTED" flag and get rid of "dwc->nollp"
> >      as separate variable.
> >  -   Make "dw_dma_slave" documentation comments more clear about
> > quirks.
> >      "is_memcpy" and "is_private" are quirks, "is_nollp" is regular 
> >      pdata property.
> > 
> > Eugeniy Paltsev (3):
> >   dmaengine: DW DMAC: split pdata to hardware properties and
> > platform
> >     quirks
> >   dmaengine: DW DMAC: convert to unified device property API
> >   dmaengine: DW DMAC: move "nollp" to "dwc->flags"
> > 
> >  drivers/dma/dw/core.c                | 34 +++++++++++++----------
> >  drivers/dma/dw/platform.c            | 53 +++++++++++++++++++----
> > ---
> > ----------
> >  drivers/dma/dw/regs.h                |  2 +-
> >  include/linux/platform_data/dma-dw.h |  5 ++++
> >  4 files changed, 54 insertions(+), 40 deletions(-)
> > 
> 
> -- 
>  Paltsev Eugeniy

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy