linux-kernel - RE: [PATCH V3 4/9] Documentation: devicetree: mfd: da9062/61 MFD binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2016 15:28:39 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     DEVICETREE <devicetree@...r.kernel.org>,
        LINUX-INPUT <linux-input@...r.kernel.org>,
        LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        LINUX-PM <linux-pm@...r.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Support Opensource <Support.Opensource@...semi.com>,
        Wim Van Sebroeck <wim@...ana.be>,
        Zhang Rui <rui.zhang@...el.com>
Subject: RE: [PATCH V3 4/9] Documentation: devicetree: mfd: da9062/61 MFD
 binding

On 02 November 2016 14:32, Lee Jones wrote:

> On Mon, 31 Oct 2016, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > [...]
> >
> > +- onkey : See ../input/da9062-onkey.txt
> > +
> > +
> > +- watchdog: See ../watchdog/da9062-watchdog.txt
> > +
> > +
> > +- thermal : See ../thermal/da9062-thermal.txt
> 
> Remove all those extra lines in between.

Ok.

> >  Example:
> > @@ -64,10 +96,6 @@ Example:
> >  			compatible = "dlg,da9062-rtc";
> >  		};
> >
> > -		watchdog {
> > -			compatible = "dlg,da9062-watchdog";
> > -		};
> > -
> 
> Why don't you include a sub-node per child device and use
> of_platform_populate() to register the devices?

In this case I'm just moving the binding descriptions into a
different file. I'm not sure I understand what you mean here.
What do you have in mind?

Regards,
Steve