linux-kernel - Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87twbk9cg8.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 7 Nov 2016 03:50:00 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
CC:     Archit Taneja <architt@...eaurora.org>,
        Mark Brown <broonie@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Fabio Estevam <fabio.estevam@...escale.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Koji Matsuoka <koji.matsuoka.xm@...esas.com>,
        Thierry Reding <treding@...dia.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Simon <horms@...ge.net.au>, <linux-renesas-soc@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support


Hi Russell

> > +	platform = platform_device_register_full(&pdevinfo);
> > +	if (IS_ERR_OR_NULL(platform))
> > +		return PTR_ERR(platform);
> 
> This is wrong.  If platform is NULL, PTR_ERR() will return zero, which
> will be interpreted as success.  Please, avoid using IS_ERR_OR_NULL(),
> it leads to exactly this kind of cockup - and it's unnecessary here
> because platform_device_register_full() does not return NULL.

Thank you for your feedback.
Before sending v4 patch, I would like to confirm. Do you meand this ?
# use IS_ERR() instead of IS_ERR_OR_NULL()

	platform = platform_device_register_full(&pdevinfo);
	if (IS_ERR(platform))
		return PTR_ERR(platform);