linux-kernel - Re: [PATCH] arm/vdso: introduce vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d3a03e0-43ad-1e6f-a065-17e5bfdd92f4@virtuozzo.com>
Date:   Mon, 7 Nov 2016 21:36:48 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
CC:     <linux-kernel@...r.kernel.org>, <0x7f454c46@...il.com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Christopher Covington <cov@...eaurora.org>,
        "Andy Lutomirski" <luto@...capital.net>,
        Oleg Nesterov <oleg@...hat.com>,
        "Will Deacon" <will.deacon@....com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-mm@...ck.org>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Pavel Emelyanov <xemul@...tuozzo.com>
Subject: Re: [PATCH] arm/vdso: introduce vdso_mremap hook

On 11/07/2016 09:27 PM, Russell King - ARM Linux wrote:
> On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
>> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
>> index 53cf86cf2d1a..d1001f87c2f6 100644
>> --- a/arch/arm/kernel/vdso.c
>> +++ b/arch/arm/kernel/vdso.c
>> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
>>  	.pages = &vdso_data_page,
>>  };
>>
>> +static int vdso_mremap(const struct vm_special_mapping *sm,
>> +		struct vm_area_struct *new_vma);
>
> I'd much rather avoid this forward declaration.  Is there any reason the
> function body can't be here?
>

Well, I didn't want it to be in the middle of static file variables -
those looks nice at this moment just on top of the file.
No other than that.

-- 
              Dmitry