linux-kernel - Re: [RFC] proc: don't show kernel-internal mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <623d3267-2189-2f33-1805-2691769b87a7@virtuozzo.com>
Date:   Mon, 7 Nov 2016 20:30:46 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
CC:     <linux-kernel@...r.kernel.org>, <0x7f454c46@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Andrey Vagin <avagin@...nvz.org>, Rob Landley <rob@...dley.net>
Subject: Re: [RFC] proc: don't show kernel-internal mnt_id in fdinfo (if
 possible)

On 11/07/2016 08:06 PM, Eric W. Biederman wrote:
> Dmitry Safonov <dsafonov@...tuozzo.com> writes:
>
>> Some kernel special fs could be mounted by userspace, let's show
>> userspace mnt_id in those cases.
>
> You are asking the kernel to lie to userspace in the case when
> the truth in inconvenient.  That seems blantantly wrong.
>
> In the case of an internal mount you may want to use the device id
> of the device the filesystem is mounted on so you can tie all of
> the mounts together.  That would allow restore and other things
> to do something useful.
>
> That information is available with fstat on a file descriptor so I don't
> think we need to export it.  But if it is not available I can see
> the point of a patch.
>
> Outright ling to userpsace.  No.  That is just horrible.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Ah, ok right, I see your point - then let's just drop the patch.

Thanks,
              Dmitry