linux-kernel - Re: [PATCHv7 07/11] i2c: match dt-style device names from sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69b56515-2799-0c16-06a5-d3709d0be751@osg.samsung.com>
Date:   Mon, 7 Nov 2016 16:10:51 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Kieran Bingham <kieran@...uared.org.uk>,
        Wolfram Sang <wsa@...-dreams.de>,
        Lee Jones <lee.jones@...aro.org>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        sameo@...ux.intel.com
Subject: Re: [PATCHv7 07/11] i2c: match dt-style device names from sysfs
 interface

Hello Kieran,

On 11/07/2016 09:47 AM, Kieran Bingham wrote:
> A user can choose to instantiate a device on an i2c bus using the sysfs
> interface by providing a string and address to match and communicate
> with the device on the bus. Presently this string is only matched
> against the old i2c device id style strings, even in the presence of
> full device tree compatible strings with vendor prefixes.
> 
> Providing a vendor-prefixed string to the sysfs interface will not match
> against the device tree of_match_device() calls as there is no device
> tree node to parse from the sysfs interface.
> 
> Convert i2c_of_match_device_strip_vendor() such that it can match both
> vendor prefixed and stripped compatible strings on the sysfs interface.
> 
> Signed-off-by: Kieran Bingham <kieran@...gham.xyz>
>

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America