linux-kernel - Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal string length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d2b30a0-78fa-7232-8fd2-dab6ec24e504@osg.samsung.com>
Date:   Mon, 7 Nov 2016 16:12:09 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Kieran Bingham <kieran@...uared.org.uk>,
        Wolfram Sang <wsa@...-dreams.de>,
        Lee Jones <lee.jones@...aro.org>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        sameo@...ux.intel.com
Subject: Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal
 string length

Hello Kieran,

On 11/07/2016 09:47 AM, Kieran Bingham wrote:
> If a user provides a shortened string to match a device to the sysfs i2c
> interface it will match on the first string that contains that string
> prefix.
> 
> for example:
>   echo a 0x68 > /sys/bus/i2c/devices/i2c-2/new_device
> will match as3711, as3722, and ak8975 incorrectly.
> 
> Correct this by using sysfs_streq to match the string exactly
> 
> Signed-off-by: Kieran Bingham <kieran@...gham.xyz>
> 

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America