linux-kernel - Re: [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96662E15-7BBE-41BB-9CEB-07BBA34AA90A@intel.com>
Date:   Mon, 7 Nov 2016 21:20:30 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     Nicholas Hanley <nicholasjhanley@...il.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Simmons <jsimmons@...radead.org>,
        "Lustre Development List" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: use bool assignment to
 true/false

On Nov 7, 2016, at 12:01, Nicholas Hanley <nicholasjhanley@...il.com> wrote:
> 
> Replace 0 with false in tx_pages_mapped = 0 to be consistent with
> the rest of the lustre code.
> 
> Signed-off-by: Nicholas Hanley <nicholasjhanley@...il.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> index 13235b0..e2fc65f 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> {
> 	__u64 *pages = tx->tx_pages;
> 	bool is_rx = (rd != tx->tx_rd);
> -	bool tx_pages_mapped = 0;
> +	bool tx_pages_mapped = false;
> 	struct kib_fmr_pool *fpo;
> 	int npages = 0;
> 	__u64 version;
> -- 
> 2.10.2
>