linux-kernel - Re: [PATCH] media: s5p-mfc include buffer size in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8078d0e6-246b-e8f3-ec62-41e9d543909f@osg.samsung.com>
Date:   Mon, 7 Nov 2016 16:40:14 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:     kyungmin.park@...sung.com, kamil@...as.org, jtp.park@...sung.com,
        a.hajda@...sung.com, mchehab@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: s5p-mfc include buffer size in error message

On 11/04/2016 04:05 AM, Sylwester Nawrocki wrote:
> On 10/18/2016 02:43 AM, Shuah Khan wrote:
>> Include buffer size in s5p_mfc_alloc_priv_buf() the error message when it
>> fails to allocate the buffer. Remove the debug message that does the same.
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> index 1e72502..eee16a1 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> @@ -40,12 +40,11 @@ void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
>>  int s5p_mfc_alloc_priv_buf(struct device *dev, dma_addr_t base,
>>  					struct s5p_mfc_priv_buf *b)
>>  {
>> -	mfc_debug(3, "Allocating priv: %zu\n", b->size);
> 
> How about keeping this debug message, I think it would be useful
> to leave that information in the debug logs.

Sent v2 with just the error message change.

thanks,
-- Shuah

> 
>>  	b->virt = dma_alloc_coherent(dev, b->size, &b->dma, GFP_KERNEL);
>>  
>>  	if (!b->virt) {
>> -		mfc_err("Allocating private buffer failed\n");
>> +		mfc_err("Allocating private buffer of size %zu failed\n",
>> +			b->size);
>>  		return -ENOMEM;
>>  	}
> 
> --
> Thanks,
> Sylwester
>