linux-kernel - Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87shr2lug3.fsf@concordia.ellerman.id.au>
Date:   Tue, 08 Nov 2016 10:51:56 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Laurent Dufour <ldufour@...ux.vnet.ibm.com>,
        Christopher Covington <cov@...eaurora.org>, criu@...nvz.org,
        Will Deacon <will.deacon@....com>, linux-mm@...ck.org
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions

Laurent Dufour <ldufour@...ux.vnet.ibm.com> writes:

> On 04/11/2016 05:59, Michael Ellerman wrote:
>> Christopher Covington <cov@...eaurora.org> writes:
>> 
>>> The PowerPC VDSO remap and unmap code was copied to a generic location,
>>> only modifying the variable name expected in mm->context (vdso instead of
>>> vdso_base) to match most other architectures. Having adopted this generic
>>> naming, drop the code in arch/powerpc and use the generic version.
>>>
>>> Signed-off-by: Christopher Covington <cov@...eaurora.org>
>>> ---
>>>  arch/powerpc/Kconfig                     |  1 +
>>>  arch/powerpc/include/asm/Kbuild          |  1 +
>>>  arch/powerpc/include/asm/mm-arch-hooks.h | 28 -------------------------
>>>  arch/powerpc/include/asm/mmu_context.h   | 35 +-------------------------------
>>>  4 files changed, 3 insertions(+), 62 deletions(-)
>>>  delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h
>> 
>> This looks OK.
>> 
>> Have you tested it on powerpc? I could but I don't know how to actually
>> trigger these paths, I assume I need a CRIU setup?
>
> FWIW, tested on ppc64le using a sample test process moving its VDSO and
> then catching a signal on 4.9-rc4 and using CRIU on top of 4.8 with
> sightly changes to due minor upstream changes.
>
> Reviewed-by: Laurent Dufour <ldufour@...ux.vnet.ibm.com>
> Tested-by: Laurent Dufour <ldufour@...ux.vnet.ibm.com>

Thanks, in that case:

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers