linux-kernel - Re: [PATCH] serial: sirf: Simplify a test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr>
Date:   Tue, 8 Nov 2016 08:18:04 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org
Cc:     baohua@...nel.org, gregkh@...uxfoundation.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, jslaby@...e.com
Subject: Re: [PATCH] serial: sirf: Simplify a test

Le 07/11/2016 à 14:50, Arnd Bergmann a écrit :
> On Tuesday, November 1, 2016 8:03:33 AM CET Christophe JAILLET wrote:
>> 'dmaengine_prep_dma_cyclic()' does not return an error pointer, so the test
>> can be simplified to be more consistent.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> The change looks correct in principle. It would be good to automate looking
> for other instances of this bug. How did you find it? Do you have e.g. a
> coccinelle script or did you just stumble over the issue by accident?
Hi,

You can have an idea of the strategy used in this post:
    https://lkml.org/lkml/2016/11/1/388

Julia is currently working on a more complete strategy in order to find 
such issues.

In the meantime, if you want, I can send the coccinelle scripts used.

Best regards,
CJ