linux-kernel - Re: [PATCH v5 2/7] Input: synaptics-rmi4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161108014907.GD10133@dtor-ws>
Date:   Mon, 7 Nov 2016 17:49:07 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Nick Dyer <nick@...anahar.org>
Cc:     Andrew Duggan <aduggan@...aptics.com>,
        Chris Healy <cphealy@...il.com>,
        Henrik Rydberg <rydberg@...math.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug
 lines

On Mon, Oct 24, 2016 at 10:51:52PM +0100, Nick Dyer wrote:
> Signed-off-by: Nick Dyer <nick@...anahar.org>

Applied, thank you.

> ---
>  drivers/input/rmi4/rmi_bus.c    | 3 +++
>  drivers/input/rmi4/rmi_driver.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> index ef8c747..3c6a1b5 100644
> --- a/drivers/input/rmi4/rmi_bus.c
> +++ b/drivers/input/rmi4/rmi_bus.c
> @@ -230,6 +230,9 @@ int rmi_register_function(struct rmi_function *fn)
>  
>  void rmi_unregister_function(struct rmi_function *fn)
>  {
> +	rmi_dbg(RMI_DEBUG_CORE, &fn->dev, "Unregistering F%02X.\n",
> +			fn->fd.function_number);
> +
>  	device_del(&fn->dev);
>  	of_node_put(fn->dev.of_node);
>  	put_device(&fn->dev);
> diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
> index 63c9e22..adb3ee8 100644
> --- a/drivers/input/rmi4/rmi_driver.c
> +++ b/drivers/input/rmi4/rmi_driver.c
> @@ -722,6 +722,7 @@ static int rmi_initial_reset(struct rmi_device *rmi_dev,
>  			return RMI_SCAN_DONE;
>  		}
>  
> +		rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, "Sending reset\n");
>  		error = rmi_write_block(rmi_dev, cmd_addr, &cmd_buf, 1);
>  		if (error) {
>  			dev_err(&rmi_dev->dev,
> -- 
> 2.7.4
> 

-- 
Dmitry