[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20161108134937.1966206-1-arnd@arndb.de>
Date: Tue, 8 Nov 2016 14:48:59 +0100
From: Arnd Bergmann <arnd@...db.de>
To: Vinod Koul <vinod.koul@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>,
Dan Williams <dan.j.williams@...el.com>,
Sinan Kaya <okaya@...eaurora.org>, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] dmaengine: qcom_hidma: hide MSI handler when unused
The newly added MSI support causes a harmless warning when MSI
is disabled:
drivers/dma/qcom/hidma.c:558:20: error: 'hidma_chirq_handler_msi' defined but not used [-Werror=unused-function]
This adds another #ifdef to match that around the users of the function.
Fixes: 1c0e3e82a7fb ("dmaengine: qcom_hidma: add MSI support for interrupts")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
drivers/dma/qcom/hidma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index d5e7991ad737..10425e134e06 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -555,6 +555,7 @@ static irqreturn_t hidma_chirq_handler(int chirq, void *arg)
return hidma_ll_inthandler(chirq, lldev);
}
+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
{
struct hidma_lldev **lldevp = arg;
@@ -563,6 +564,7 @@ static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg)
return hidma_ll_inthandler_msi(chirq, *lldevp,
1 << (chirq - dmadev->msi_virqbase));
}
+#endif
static ssize_t hidma_show_values(struct device *dev,
struct device_attribute *attr, char *buf)
--
2.9.0
Powered by blists - more mailing lists