linux-kernel - Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e17837bb-5856-63f8-5c32-3108651fbb65@ti.com>
Date:   Tue, 8 Nov 2016 20:16:07 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Axel Haslam <ahaslam@...libre.com>,
        Kevin Hilman <khilman@...libre.com>
CC:     Alexandre Courbot <gnurou@...il.com>,
        David Lechner <david@...hnology.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "J, KEERTHY" <j-keerthy@...com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: davinci: Use unique labels for each gpio chip

On Tuesday 08 November 2016 07:01 PM, Linus Walleij wrote:
> On Thu, Nov 3, 2016 at 12:34 PM, Axel Haslam <ahaslam@...libre.com> wrote:
> 
>> The gpiod framework uses the chip label to match a specific chip.
>> The davinci gpio driver, creates several chips using always the same
>> label, which is not compatible with gpiod.
>>
>> To allow platform data to declare gpio lookup tables, and for drivers
>> to use the gpiod framework, allocate unique label per registered chip.
>>
>> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> 
> Sekhar/Kevin: can either of you review this patch?

The patch looks good to me.

Reviewed-by: Sekhar Nori <nsekhar@...com>

I am traveling and did not really test the patch.

Thanks,
Sekhar