linux-kernel - Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon Djtag driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4faf6fbc-cbce-f727-4f8a-502b6eb3f406@huawei.com>
Date:   Tue, 8 Nov 2016 15:17:45 +0000
From:   John Garry <john.garry@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        Anurup M <anurupvasu@...il.com>, <anurup.m@...wei.com>,
        <linux-kernel@...r.kernel.org>, <mark.rutland@....com>,
        <shyju.pv@...wei.com>, <gabriele.paoloni@...wei.com>,
        <will.deacon@....com>, <linuxarm@...wei.com>,
        <xuwei5@...ilicon.com>, <zhangshaokun@...ilicon.com>,
        <sanil.kumar@...ilicon.com>, <tanxiaojun@...wei.com>,
        <shiju.jose@...wei.com>
Subject: Re: [PATCH v1 03/11] drivers: soc: hisi: Add support for Hisilicon
 Djtag driver

On 08/11/2016 15:10, Arnd Bergmann wrote:
> On Tuesday, November 8, 2016 1:49:43 PM CET John Garry wrote:
>>
>> Hi Arnd,
>>
>> Thanks for the reference.
>>
>> I think the i2c interface doesn't fully satisfy our requirements as we
>> need more than just a slave bus address when accessing the slave device
>> (which I think is what i2c uses). We also need to pass "offset" and
>> "mod_mask" arguments to the djtag adapter to access specific registers
>> in the slave device.
>
> Ok. Are those values constant per device, or maybe a range? We may want to
> include those in the reg property as well then.
>
> 	Arnd
>

Hi Arnd,

I'm not sure, I'll defer to Tan/Anurup.

Cheers,
John

>
> .
>