linux-kernel - Re: [PATCH] drm/amdgpu/powerplay/smu7: fix unintialized data usage

Open Source and information security mailing list archives

Message-ID: <CADnq5_MFfBs5i3u7BvUCTy+teWqhS9reucX_qMsv3QnpgHSLkg@mail.gmail.com>
Date:   Tue, 8 Nov 2016 10:35:46 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Tom St Denis <tom.stdenis@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, Rex Zhu <Rex.Zhu@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu/powerplay/smu7: fix unintialized data usage

On Tue, Nov 8, 2016 at 8:52 AM, Arnd Bergmann <arnd@...db.de> wrote:
> A recent bugfix replaced an out-of-bounds access with direct
> use of unintialized data:
>
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_patch_limits_vddc':
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:11: note: 'vddc' was declared here
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddci' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:17: note: 'vddci' was declared here
>   uint32_t vddc, vddci;
>
> This initializes the data as before using the correct type.
>
> Fixes: 77f7f71f5be1 ("drm/amdgpu/powerplay/smu7: fix static checker warning")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 9e49f2777143..b2d61d043d52 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -2147,9 +2147,11 @@ static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr,
>         struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
>
>         if (tab) {
> +               vddc = tab->vddc;
>                 smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddc,
>                                                    &data->vddc_leakage);
>                 tab->vddc = vddc;
> +               vddci = tab->vddci;
>                 smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddci,
>                                                    &data->vddci_leakage);
>                 tab->vddci = vddci;
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives