linux-kernel - Re: [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY2aMcv_Sko7PQGn3DE1nm=osypGcR5bWUx69CzUj-o1Q@mail.gmail.com>
Date:   Tue, 8 Nov 2016 16:40:37 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency

On Tue, Nov 8, 2016 at 2:59 PM, Arnd Bergmann <arnd@...db.de> wrote:

> The new mpu3050 driver fails to build if I2C is disabled:
>
> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_exit':
> mpu3050-i2c.c:(.exit.text+0x17f): undefined reference to `i2c_del_driver'
> drivers/iio/built-in.o: In function `mpu3050_i2c_driver_init':
> mpu3050-i2c.c:(.init.text+0x215): undefined reference to `i2c_register_driver'
>
> This adds a Kconfig dependency to ensure we only build it when I2C
> is available.
>
> Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij