linux-kernel - Re: [PATCH] drbd: Fix kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161108161324.GH19539@ZenIV.linux.org.uk>
Date:   Tue, 8 Nov 2016 16:13:24 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Richard Weinberger <richard@....at>, drbd-dev@...ts.linbit.com,
        linux-kernel@...r.kernel.org, lars.ellenberg@...bit.com,
        philipp.reisner@...bit.com, stable@...r.kernel.org,
        christoph.lechleitner@...g.at, wolfgang.glas@...g.at
Subject: Re: [PATCH] drbd: Fix kernel_sendmsg() usage

On Tue, Nov 08, 2016 at 07:49:24AM -0800, Christoph Hellwig wrote:
> On Tue, Nov 08, 2016 at 11:43:09AM +0100, Richard Weinberger wrote:
> > Don't pass a size larger than iov_len to kernel_sendmsg().
> > Otherwise it will cause a NULL pointer deref when kernel_sendmsg()
> > returns with rv < size.
> > 
> > Although the issue exists since day 0, only on non-ancient kernels
> > that contain change 57be5bdad759 ("ip: convert tcp_sendmsg() to iov_iter
> > primitives") it seems to trigger [0][1][2][3][4].
> 
> The real fix here is to convert it to the right primitive, e.g. take
> Al's patch from here:
> 
> https://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.sendmsg&id=7a4992299554a9e1ed3c4540bcfa9e40aa9a6376

_After_ the backport-friendly part, please.  And that's my ACK-by
on Richard's variant.