linux-kernel - Re: [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161108201114.GQ3117@twins.programming.kicks-ass.net>
Date:   Tue, 8 Nov 2016 21:11:14 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Zhi Li <lznuaa@...il.com>
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Frank Li <Frank.Li@....com>, Shawn Guo <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>, acme@...nel.org,
        alexander.shishkin@...ux.intel.com,
        Mark Rutland <mark.rutland@....com>,
        jerry shen <jerry.zhengyu.shen@...il.com>,
        Zhengyu Shen <zhengyu.shen@....com>
Subject: Re: [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver

On Tue, Nov 08, 2016 at 01:21:47PM -0600, Zhi Li wrote:
> On Tue, Nov 8, 2016 at 1:00 PM, Paul Gortmaker
> > I just noticed this commit now that linux-next is back after the week off.
> >
> > This should probably use core_param or setup_param since the Kconfig
> > for this is bool and not tristate. 


> I think pmu_pmu_poll_period_us should be removed because no benefit to
> change it.
> I can delete .remove

Why not make it tristate ?