linux-kernel - Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1478641235.2341.29.camel@intel.com>
Date:   Tue, 08 Nov 2016 13:40:35 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     apw@...onical.com, joe@...ches.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote:
> When users run checkpatch.pl with --no-tree option, $root is not
> defined, which causes an ugly warning that it is not initialized at
> line 764.  The test for whether or not a file is maintained should
> only be run when a kernel tree is defined (i.e. not when --no-tree
> option is being used)
> 
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping? Joe? Andy?  Where are we at with this patch?

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..7a54978 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2352,7 +2352,7 @@ sub process {
>  			}
>  		}
>  
> -		if ($found_file) {
> +		if ($found_file && $tree) {
>  			if (is_maintained_obsolete($realfile)) {
>  				WARN("OBSOLETE",
>  				     "$realfile is marked as 'obsolete'
> in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)