linux-kernel - Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161109000032.GA71749@google.com>
Date:   Tue, 8 Nov 2016 16:00:32 -0800
From:   Brian Norris <computersforpeace@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Jerome Forissier <jerome.forissier@...aro.org>
Subject: Re: [PATCH] checkpatch: fix uninitialized var when run with --no-tree

On Tue, Nov 08, 2016 at 03:10:40PM -0800, Andrew Morton wrote:
> I already have the below.  Good enough?

Sure, good enough. Though it does have the same tiny awkwardness as my
v1.

> From: Jerome Forissier <jerome.forissier@...aro.org>
> Subject: checkpatch: don't try to get maintained status when --no-tree is given
> 
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
> 
> Link: http://lkml.kernel.org/r/1476719709-16668-1-git-send-email-jerome.forissier@linaro.org
> Signed-off-by: Jerome Forissier <jerome.forissier@...aro.org>
> Acked-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  scripts/checkpatch.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given scripts/checkpatch.pl
> --- a/scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given
> +++ a/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
>  
> _
> 

FWIW:

Reviewed-by: Brian Norris <computersforpeace@...il.com>