linux-kernel - drm/bridge: analogix_dp: clear psr_support when disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1478663614-9914-1-git-send-email-wxt@rock-chips.com>
Date:   Wed,  9 Nov 2016 11:53:34 +0800
From:   Caesar Wang <wxt@...k-chips.com>
To:     seanpaul@...omium.org
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        tomeu.vizoso@...labora.com, linux-rockchip@...ts.infradead.org,
        marcheu@...omium.org, zain wang <wzz@...k-chips.com>,
        Caesar Wang <wxt@...k-chips.com>
Subject: drm/bridge: analogix_dp: clear psr_support when disable_bridge

From: zain wang <wzz@...k-chips.com>

Don't run psr work during enabling bridge when you restart ui, it may make
link training fail since there is a race between them in AUX CH resource.

Signed-off-by: zain wang <wzz@...k-chips.com>
Signed-off-by: Caesar Wang <wxt@...k-chips.com>
Cc: Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc: dri-devel@...ts.freedesktop.org
Cc: Sean Paul <seanpaul@...omium.org>

---
BTW:
- The training issue is gone with this patch,
  there are four machines have passed the 10000 cycles with S2R tests.
- Verified on ChromeOS kernelv4.4.

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 6e0447f..4431f62 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1117,6 +1117,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
 	if (ret)
 		DRM_ERROR("failed to setup the panel ret = %d\n", ret);
 
+	dp->psr_support = false;
 	dp->dpms_mode = DRM_MODE_DPMS_OFF;
 }
 
-- 
2.7.4