lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Nov 2016 13:35:27 +0900 From: Masahiro Yamada <yamada.masahiro@...ionext.com> To: linux-mtd@...ts.infradead.org Cc: Alan Cox <alan@...ux.intel.com>, David Woodhouse <David.Woodhouse@...el.com>, Jason Roberts <jason.e.roberts@...el.com>, Chuanxiao Dong <chuanxiao.dong@...el.com>, Dinh Nguyen <dinguyen@...era.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, linux-kernel@...r.kernel.org, Boris Brezillon <boris.brezillon@...e-electrons.com>, Marek Vasut <marek.vasut@...il.com>, Brian Norris <computersforpeace@...il.com>, Richard Weinberger <richard@....at>, David Woodhouse <dwmw2@...radead.org>, Cyrille Pitchen <cyrille.pitchen@...el.com> Subject: [PATCH 08/11] mtd: nand: denali: return error code from devm_request_irq() on error The devm_request_irq() returns an appropriate error value when it fails. Use it instead of the fixed -ENODEV. While we are here, reword the comment to make it fit in a single line, fixing the misspelling of "initialization". Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> --- drivers/mtd/nand/denali.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 44e075a..f188a48 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1451,14 +1451,12 @@ int denali_init(struct denali_nand_info *denali) denali_hw_init(denali); denali_drv_init(denali); - /* - * denali_isr register is done after all the hardware - * initilization is finished - */ - if (devm_request_irq(denali->dev, denali->irq, denali_isr, IRQF_SHARED, - DENALI_NAND_NAME, denali)) { + /* request IRQ after all the hardware initialization is finished */ + ret = devm_request_irq(denali->dev, denali->irq, denali_isr, + IRQF_SHARED, DENALI_NAND_NAME, denali); + if (ret) { dev_err(denali->dev, "Unable to request IRQ\n"); - return -ENODEV; + return ret; } /* now that our ISR is registered, we can enable interrupts */ -- 1.9.1
Powered by blists - more mailing lists