linux-kernel - Re: [PATCH] drivers: tca8418: Change the interrupt type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Nov 2016 09:02:35 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: tca8418: Change the interrupt type

Hello Dmitry,

On Tue, Nov 08, 2016 at 04:04:00PM -0800, Dmitry Torokhov wrote:
> On Mon, Nov 07, 2016 at 03:40:24PM +0100, Maxime Ripard wrote:
> > The TCA8418 interrupt has a level trigger, not a edge one.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> 
> Hmm, maybe we could rely on OF data for trigger type?

We might, even though the i2c core doesn't change the trigger type
when it retrieves the interrupt from the DT.

However, I'm a bit worried about the other probing mechanims (ACPI,
board files) that should be supported as well, and removing the
trigger type from the flags might break those. There's no board files
using it though in the tree, but I don't know about ACPI systems.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)