linux-kernel - Re: [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161109091917.pj467vump6c2nzqm@pd.tnic>
Date:   Wed, 9 Nov 2016 10:19:17 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Gayatri Kammela <gayatri.kammela@...el.com>
Cc:     mingo@...e.hu, linux-kernel@...r.kernel.org, x86@...nel.org,
        "H . Peter Anvin" <hpa@...ux.intel.com>,
        Ravi Shankar <ravi.v.shankar@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

On Tue, Nov 08, 2016 at 04:08:44PM -0800, Gayatri Kammela wrote:
> Modify cpufeatures.h to add new AVX512 instruction groups/features
> for enuermation in /proc/cpuinfo: AVX512IFMA and AVX512VBMI
> 
> Also modify the xstate.c to clear the flags in
> fpu__xstate_clear_all_cpu_caps().

This is already visible in the diff itself, no need to explain what the
patch does.

Also, please run your commit message through a spellchecker.

> CPUID.(EAX=7,ECX=0):EBX[bit 21] AVX512IFMA
> CPUID.(Eax=7,ECX=0):ECX[bit 1]  AVX512VBMI

s/Eax/EAX/

> Detailed information of cpuid bits for the features can be found in
> Intel Architecture Instruction Set Extensions Programming Reference.

We have recently started uploading such documents into
bugzilla.kernel.org in order to have a stable reference source, see

https://lkml.kernel.org/r/alpine.DEB.2.20.1611082002160.3501@nanos

Please do so too and add the link to the commit message.

Rest looks ok to me.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.