linux-kernel - Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161109095825.GE14744@localhost>
Date:   Wed, 9 Nov 2016 10:58:25 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Johan Hovold <johan@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Mugunthan V N <mugunthanvnm@...com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and
 of_node leaks

On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote:
> 
> 
> On 11/03/2016 12:40 PM, Johan Hovold wrote:
> > Make sure to drop the references taken by of_get_child_by_name() and
> > bus_find_device() before returning from cpsw_phy_sel().
> >
> > Note that holding a reference to the cpsw-phy-sel device does not
> > prevent the devres-managed private data from going away.
> >
> > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...")
> > Cc: Mugunthan V N <mugunthanvnm@...com>
> > Cc: Grygorii Strashko <grygorii.strashko@...com>
> > Cc: linux-omap@...r.kernel.org
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> 
> Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

Thanks for the review. Note that David has already applied these, though.

Johan