linux-kernel - Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oa1pscne.wl%kuninori.morimoto.gx@renesas.com>
Date:   Wed, 9 Nov 2016 00:47:36 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
CC:     Archit Taneja <architt@...eaurora.org>,
        Mark Brown <broonie@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Fabio Estevam <fabio.estevam@...escale.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Koji Matsuoka <koji.matsuoka.xm@...esas.com>,
        Thierry Reding <treding@...dia.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Simon <horms@...ge.net.au>, <linux-renesas-soc@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support


Hi Russell

> > @@ -11,4 +11,11 @@ struct dw_hdmi_audio_data {
> >  	u8 *eld;
> >  };
> >  
> > +struct dw_hdmi_i2s_audio_data {
> > +	struct dw_hdmi *hdmi;
> > +
> > +	void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
> > +	u8 (*read)(struct dw_hdmi *hdmi, int offset);
> > +};
> 
> Another slight concern here is why we need this separate data for i2s -
> maybe adding the write/read ops to struct dw_hdmi_audio_data would be
> a better thing to do, which would then allow the AHB audio to drop
> the .base argument in the future.
> 
> I'm not that bothered about this though.  So...

Thank you for your feedback.
Maybe we can merge these in incremental patch if needed ?