linux-kernel - Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161109012725.GA29930@fieldses.org>
Date:   Tue, 8 Nov 2016 20:27:25 -0500
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Jeff Layton <jlayton@...chiereds.net>,
        linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs/nfsd/nfs4callback: Remove deprecated
 create_singlethread_workqueue

On Tue, Nov 08, 2016 at 05:52:21PM -0500, Tejun Heo wrote:
> Hello, Bruce.
> 
> On Tue, Nov 08, 2016 at 04:39:11PM -0500, J. Bruce Fields wrote:
> > Apologies, just cleaning out old mail and finding some I should have
> > responded to long ago:
> > 
> > On Wed, Aug 31, 2016 at 02:23:48AM +0530, Bhaktipriya Shridhar wrote:
> > > The workqueue "callback_wq" queues a single work item &cb->cb_work per
> > > nfsd4_callback instance and thus, it doesn't require execution ordering.
> > 
> > What's "execution ordering"?
> > 
> > We definitely do depend on the fact that at most one of these is running
> > at a time.
> 
> If there can be multiple cb's and thus cb->cb_work's per callback_wq,
> it'd need explicit ordering.  Is that the case?

Yes, there can be multiple cb_work's.

--b.