linux-kernel - Re: [PATCH 2/4] perf hist browser: Show folded sign properly on --hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161109142937.GG12125@kernel.org>
Date:   Wed, 9 Nov 2016 11:29:37 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Markus Trippelsdorf <markus@...ppelsdorf.de>
Subject: Re: [PATCH 2/4] perf hist browser: Show folded sign properly on
 --hierarchy

Em Wed, Nov 09, 2016 at 11:28:11AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 08, 2016 at 10:08:31PM +0900, Namhyung Kim escreveu:
> > When horizontall scrolling is used in hierarchy mode, the folded signed
> > disappears at the right most column.
> 
> Humm, this indeed shows the '+' folded signal after pressing ->, but it
> moves from the first to the third column :-\
> 
> > +++ b/tools/perf/ui/browsers/hists.c
> > @@ -1381,8 +1381,14 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser,
> >  		}
> >  
> >  		perf_hpp_list__for_each_format(entry->hpp_list, fmt) {
> > -			ui_browser__write_nstring(&browser->b, "", 2);
> > -			width -= 2;

Also why move this invariant to both branches?

> > +			if (first) {
> > +				ui_browser__printf(&browser->b, "%c ", folded_sign);
> > +				width -= 2;
> > +				first = false;
> > +			} else {
> > +				ui_browser__write_nstring(&browser->b, "", 2);
> > +				width -= 2;
> > +			}
> >  
> >  			/*
> >  			 * No need to call hist_entry__snprintf_alignment()
> > -- 
> > 2.10.1