linux-kernel - Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shr0v24k.fsf@belgarion.home>
Date:   Wed, 09 Nov 2016 21:18:03 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable

Stephen Boyd <sboyd@...eaurora.org> writes:

> This function is passed an __iomem pointer but we use a u32
> pointer instead which makes checkers like spare complain.
> Furthermore, "lock" is a pretty poor variable name for a string
> that will go into lockdep reports and the symbol isn't marked
> static. Cleanup all this.
>
> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
Most certainly.

Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Cheers.

--
Robert