linux-kernel - Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h97guwfu.fsf@kamboji.qca.qualcomm.com>
Date:   Thu, 10 Nov 2016 00:20:53 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Amitkumar Karwar <akarwar@...vell.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org,
        Cathy Luo <cluo@...vell.com>, security@...nel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

Brian Norris <briannorris@...omium.org> writes:

> SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
> when we print them out.
>
> This can be easily noticed by connecting to a network with a 32-octet
> SSID:
>
> [ 3903.502925] mwifiex_pcie 0000:01:00.0: info: trying to associate to
> '0123456789abcdef0123456789abcdef <uninitialized mem>' bssid
> xx:xx:xx:xx:xx:xx
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Cc: <stable@...r.kernel.org>

I'm planning to push this to 4.9 if no objections.

-- 
Kalle Valo