linux-kernel - Re: [PATCH 1/2] skd: fix msix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7f301d3-4bf7-3e4f-3e7f-aed7274a80be@fb.com>
Date:   Wed, 9 Nov 2016 22:54:04 -0700
From:   Jens Axboe <axboe@...com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Christoph Hellwig <hch@....de>,
        Mike Christie <mchristi@...hat.com>,
        Hannes Reinecke <hare@...e.com>,
        Ming Lin <ming.l@....samsung.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] skd: fix msix error handling

On 11/09/2016 05:55 AM, Arnd Bergmann wrote:
> As reported by gcc -Wmaybe-uninitialized, the cleanup path for
> skd_acquire_msix tries to free the already allocated msi-x vectors
> in reverse order, but the index variable may not have been
> used yet:
>
> drivers/block/skd_main.c: In function ‘skd_acquire_irq’:
> drivers/block/skd_main.c:3890:8: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This changes the failure path to skip releasing the interrupts
> if we have not started requesting them yet.

Applied both patches, thanks Arnd.

-- 
Jens Axboe