linux-kernel - Re: [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161110060644.GA28591@kroah.com>
Date:   Thu, 10 Nov 2016 07:06:44 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Eugene Korenevsky <ekorenevsky@...il.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v4] USB hub_probe: rework ugly
 goto-into-compound-statement

On Wed, Nov 09, 2016 at 06:35:21PM +0300, Eugene Korenevsky wrote:
> Rework smelling code (goto inside compound statement). Perhaps this is
> legacy. Anyway such code is not appropriate for Linux kernel.
> 
> Changes since v3: fix typo
> Changes since v2: extract the code to static function
> Changes since v1: fix spaces instead of tab, add missing 'Signed-off-by'

changes go below the --- line, please read
Documentation/SubmittingPatches for all of the details.

thanks,

greg k-h