linux-kernel - Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2016 14:35:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mmc@...r.kernel.org,
        Jarkko Lavinen <jarkko.lavinen@...ia.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        linux-kernel@...r.kernel.org, Nicolas Pitre <nico@...xnic.net>,
        devel@...verdev.osuosl.org, Jaehoon Chung <jh80.chung@...sung.com>,
        Pierre Ossman <pierre@...man.eu>,
        Johan Hovold <johan@...nel.org>, Alex Dubov <oakad@...oo.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Tony Olech <tony.olech@...ndigitalsystems.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Sascha Sommer <saschasommer@...enet.de>,
        adi-buildroot-devel@...ts.sourceforge.net,
        Ben Dooks <ben-linux@...ff.org>, Alex Elder <elder@...nel.org>,
        linux-mediatek@...ts.infradead.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Tony Prisk <linux@...sktech.co.nz>, linux-omap@...r.kernel.org,
        Manuel Lauss <manuel.lauss@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Ludovic Desroches <ludovic.desroches@...el.com>,
        linux-usb@...r.kernel.org, Bruce Chang <brucechang@....com.tw>,
        Sonic Zhang <sonic.zhang@...log.com>,
        Harald Welte <HaraldWelte@...tech.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
> 
> sdhci_alloc_host() returns an error pointer when it fails.
> but mmc_alloc_host() cannot.
> 
> This series allow to propagate a proper error code
> when host-allocation fails.

Why?  What can we really do about the error except give up?  Why does
having a explicit error value make any difference to the caller, they
can't do anything different, right?

I suggest just leaving it as-is, it's simple, and you don't have to mess
with PTR_ERR() anywhere.

thanks,

greg k-h