linux-kernel - [PATCH] staging: lustre: lov: Fix signed wrap around when decrementing index 'i'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161110141910.25095-1-colin.king@canonical.com>
Date:   Thu, 10 Nov 2016 14:19:10 +0000
From:   Colin King <colin.king@...onical.com>
To:     Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "John L . Hammond" <john.hammond@...el.com>,
        Amitoj Kaur Chawla <amitoj1606@...il.com>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] staging: lustre: lov: Fix signed wrap around when decrementing index 'i'

From: Colin Ian King <colin.king@...onical.com>

Change predecrement compare to post decrement compare to avoid an
unsigned integer wrap-around comparisomn when decrementing in the while
loop.

Issue found with static analysis with CoverityScan, CID 1375917

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/staging/lustre/lustre/lov/lov_ea.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
index 53db170..399298c 100644
--- a/drivers/staging/lustre/lustre/lov/lov_ea.c
+++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
@@ -102,7 +102,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
 	return lsm;
 
 err:
-	while (--i >= 0)
+	while (i-- > 0)
 		kmem_cache_free(lov_oinfo_slab, lsm->lsm_oinfo[i]);
 	kvfree(lsm);
 	return NULL;
-- 
2.10.2