linux-kernel - Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161110180214.qublcnhczfmg3wsg@sirena.org.uk>
Date:   Thu, 10 Nov 2016 18:02:14 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org
Subject: Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

On Thu, Nov 10, 2016 at 06:05:59PM +0100, Peter Rosin wrote:
> On 2016-11-10 17:18, Mark Brown wrote:
> > On Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:

> >> While at it, clean up some other things as well.

> > This isn't a useful changelog, it's just saying that there's some
> > random changes for no reason.  Please make proper patches with
> > changelogs that explain them.

> It's a very uninteresting patch, I guess I made a changelog to match.
> But I can't help myself from asking a few qustions...

> Patch*es* and changelog*s*?

> Oh, you want me to split into a series of several patches? One for the
> quotes, one for the "../regultor/" removal, one for the empty
> comment removal and one for the s/pwm_reglator/pwm-regulator/ thing?

> Be careful what you ask for, you might get it...

The above is not a problem for me, indeed it's actually good as it makes
it *much* quicker and simpler for me to read the changes and figure out
if they all make sense and do what was intended.  The less the changelog
says about what the change is supposed to do and the more different
things the change does the more effort is required to work out if it's
sensible and the more chance there is of one of the changes blocking the
other ones.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)