linux-kernel - Re: [patch] staging: lustre: lov: crash in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1611101944280.31600@casper.infradead.org>
Date:   Thu, 10 Nov 2016 19:44:57 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
cc:     Oleg Drokin <oleg.drokin@...el.com>,
        "John L. Hammond" <john.hammond@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Amitoj Kaur Chawla <amitoj1606@...il.com>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] staging: lustre: lov: crash in error handling


> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
> 
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Yep. I just sent a patch to fix that. 

> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
>  	size_t oinfo_ptrs_size, lsm_size;
>  	struct lov_stripe_md *lsm;
>  	struct lov_oinfo     *loi;
> -	unsigned int i;
> +	int i;
>  
>  	LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>  
>