linux-kernel - Re: [PATCH 00/12] of: Make drivers/of/resolver.c more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161110205602.qy2ydmykt2pqwcjn@rob-hp-laptop>
Date:   Thu, 10 Nov 2016 14:56:02 -0600
From:   Rob Herring <robh@...nel.org>
To:     frowand.list@...il.com
Cc:     pantelis.antoniou@...sulko.com,
        Pantelis Antoniou <panto@...oniou-consulting.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/12] of: Make drivers/of/resolver.c more readable

On Fri, Oct 28, 2016 at 11:26:20PM -0700, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...sony.com>
> 
> drivers/of/resolve.c is a bit difficult to read.  Clean it up so
> that review of future overlay related patches will be easier.
> 
> Most of the patches are intended to be reformatting, with no functional
> change.  Patches that are expected to have a functional change are:
> 
>   Remove excessive printks to reduce clutter.
>   Update structure of code to be clearer, also remove BUG_ON()
>     Any functional change would reflect undefined behavior on bad overlay.
>     Some error message text modified.
>     BUG_ON() removed.
>   Add back an error message, restructured
> 
> The patches are grouped into sets of changes that are intended
> to be easy to verify correctness through simple inspection.
> 
> Some of the individual patches have checkpatch warnings or errors.
> But after all patches are applied, the number of errors and
> warnings from running checkpatch against the entire file are
> reduced to two line size warnings.
> 
> These patches are only tested via the unit tests. I do not have
> expansion boards to test with real hardware.
> 
> changes from rfc to v1:
>   - Remove fewer one line comments
>   - Add more extensive header comment to of_resolve_phandles()
>     to explain the how and why of resolving phandles
>   - Update patch header comments
>   - Incorporated patch "Remove braces around single line blocks"
>     into the previous patch in the series
> 
> 
> Frank Rowand (12):
>   of: Remove comments that state the obvious, to reduce clutter
>   of: Remove excessive printks to reduce clutter.
>   of: Convert comparisons to zero or NULL to logical expressions
>   of: Rename functions to more accurately reflect what they do
>   of: Remove prefix "__of_" from local function names
>   of: Rename variables to better reflect purpose or follow convention
>   of: Update structure of code to be clearer, also remove BUG_ON()
>   of: Remove redundant size check
>   of: Update comments to reflect changes and increase clarity
>   of: Add back an error message, restructured
>   of: Move setting of pointer to beside test for non-null
>   of: Remove unused variable overlay_symbols

Series applied.

Rob