linux-kernel - Re: [PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 09:56:21 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error

Hi,

On 11/11/2016 09:03 AM, Lu Baolu wrote:
> When xHCI host sees a malformed TRB in a transfer ring,
> it will generate a transfer event with the completion
> code set to COMP_TRB_ERR (5), and sets the endpoint
> state in output endpoint context to EP_STATE_ERROR.
> The endpoint enters ERROR state as the result.
>
> XHCI specification requires that Set TR Dequeue Pointer
> Command shall be used to transition the endpoint from
> Error to Stopped state. Current xHCI driver doesn't
> clear this endpoint error, hence the successive URB
> enqueue requests will result in error messages of
> "WARN waiting for error on ep to be cleared". And the
> corresponding USB device stays in unresponsive state.
>
> This patch enhances xHCI driver on this by printing out
> the malformed TRB and clearing the endpoint Error state.
>
> Tested-by: Wang Wendy <wendy.wang@...e.com>
                                                    ^^^^^
                                                    intel.com

I will correct it with a v2.

Best regards,
Lu Baolu