linux-kernel - Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <792bd56e-fa83-461c-9f36-84b023dad72e@gmail.com>
Date:   Sat, 12 Nov 2016 11:03:15 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Oliver Neukum <oneukum@...e.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Pawel Moll <pawel.moll@....com>,
        Kumar Gala <galak@...eaurora.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Alan Cooper <alcooperx@...il.com>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

Hi Chunfeng,

On 10/31/2016 04:31 AM, Chunfeng Yun wrote:
> On Fri, 2016-10-28 at 12:37 +0200, Matthias Brugger wrote:
>> Hi Chunfeng,
>>
>> On 10/19/2016 04:28 AM, Chunfeng Yun wrote:
>>> These patches introduce the MediaTek USB3 dual-role controller
>>> driver.
>>>
>>> The driver can be configured as Dual-Role Device (DRD),
>>> Peripheral Only and Host Only (xHCI) modes. It works well
>>> with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is
>>> tested on MT8173 platform which only contains USB2.0 device IP,
>>> and on MT6290 platform which contains USB3.0 device IP.
> [...]
>>>
>>> Change in v2:
>>> 1. modify binding docs according to suggestions
>>> 2. modify some comments and remove some dummy blank lines
>>> 3. fix memory leakage
>>>
>>>
>>> Chunfeng Yun (8):
>>>   dt-bindings: mt8173-xhci: support host side of dual-role mode
>>>   dt-bindings: mt8173-mtu3: add devicetree bindings
>>>   usb: xhci-mtk: make IPPC register optional
>>>   usb: Add MediaTek USB3 DRD driver
>>>   usb: mtu3: Super-Speed Peripheral mode support
>>>   usb: mtu3: host only mode support
>>>   usb: mtu3: dual-role mode support
>>>   arm64: dts: mediatek: add USB3 DRD driver
>>>
>>
>> I tried the driver with my mt8173-evb, but wasn't able to get USB
>> working (no usb stick detected when adding to the usb port).
>>
> Can you test it again by USB3.0 type-A port? If it works, then
> regulators of vusb33 and vbus are got after PROBE_DEFER of
> mt6397-regulator driver;
>

This morning I tried again, but I don't see any message in the kernel 
log when I plug in a usb stick, see the full kernel log here:
http://pastebin.com/QeicwFak


> For OTG port, need cherry pick a patch:
>
> https://patchwork.kernel.org/patch/9055261/
>

On top of v4.9-rc1, I use your patch set, the patch mentioned above. I 
attach you the config I'm using. Do you have any clue what I'm missing?

Thanks,
Matthias




> which is abandoned because GPIO driver owner wants to fix all pins with
> the same problem.
>
> Then device will be recognized well when connected to PC with OTG cable.
>
> But it is a trouble for OTG host mode, due to vbus 5.5V of OTG port is
> originally provided by charger driver which is not upstreamed on EVB
> board, we need rework the board to control vbus by gpio.
> There is a simple way, you can plug in a self-powered hub to test OTG
> host mode.
>
>
>> # dmesg |grep mtu
>> [    0.428420] mtu3 11271000.usb: failed to get vusb33
>> [    0.510570] mtu3 11271000.usb: failed to get vbus
>> [    0.592103] mtu3 11271000.usb: failed to get vbus
>>
>>
>> Relevant config options:
>> CONFIG_USB_MTU3=y
>> CONFIG_USB_MTU3_HOST=y
>> CONFIG_USB_MTU3_DEBUG=y
>> CONFIG_PHY_MT65XX_USB3=y
>>
>>
>> Looks like an error in the device tree. I can see that the mt6397
>> regulater get's initialized *after* the mtu3 driver:
>> [    0.505166] mt6397-regulator mt6397-regulator: Chip ID = 0x4097
>>
>> Not sure if this is related.
>> Any idea whats going wrong here?
>>
> as above.
>
> Sorry for inconvenience
>
>> Cheers,
>> Matthias
>
>

View attachment "config-arm64-usb-not-working" of type "text/plain" (117996 bytes)