linux-kernel - Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b30b4883-07ff-b2aa-7034-e9713e1dfca2@kernel.org>
Date:   Sat, 12 Nov 2016 16:27:32 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is
 suspended in in_illuminance_calibrate_store

On 12/11/16 16:24, Jonathan Cameron wrote:
> On 10/11/16 09:25, Brian Masney wrote:
>> in_illuminance_calibrate_store() did not check to see if the chip is
>> suspended. This patch adds the proper check. The return value from
>> taos_als_calibrate() was also not checked in this function, so the
>> proper check was also added while changes are being made here.
>>
>> Signed-off-by: Brian Masney <masneyb@...tation.org>
> Applied.
And backed out. It doesn't build :(

drivers/staging/iio/light/tsl2583.c:511:10: error: ‘struct tsl2583_chip’ has no member named ‘suspended’
  if (chip->suspended) {
          ^~

>> ---
>>  drivers/staging/iio/light/tsl2583.c | 17 ++++++++++++++---
>>  1 file changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
>> index 1a7be12..eb59ea0 100644
>> --- a/drivers/staging/iio/light/tsl2583.c
>> +++ b/drivers/staging/iio/light/tsl2583.c
>> @@ -501,16 +501,27 @@ static ssize_t in_illuminance_calibrate_store(struct device *dev,
>>  {
>>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>>  	struct tsl2583_chip *chip = iio_priv(indio_dev);
>> -	int value;
>> +	int value, ret;
>>  
>>  	if (kstrtoint(buf, 0, &value) || value != 1)
>>  		return -EINVAL;
>>  
>>  	mutex_lock(&chip->als_mutex);
>> -	taos_als_calibrate(indio_dev);
>> +
>> +	if (chip->suspended) {
>> +		ret = -EBUSY;
>> +		goto done;
>> +	}
>> +
>> +	ret = taos_als_calibrate(indio_dev);
>> +	if (ret < 0)
>> +		goto done;
>> +
>> +	ret = len;
>> +done:
>>  	mutex_unlock(&chip->als_mutex);
>>  
>> -	return len;
>> +	return ret;
>>  }
>>  
>>  static ssize_t in_illuminance_lux_table_show(struct device *dev,
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>