linux-kernel - Re: [PATCH] Input: psmouse - disable automatic probing of BYD touchpads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201611122039.33245@pali>
Date:   Sat, 12 Nov 2016 20:39:32 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Chris Diamand <chris@...mand.org>, phonesyfreakies@...il.com,
        Michael Shell <list1@...haelshell.org>,
        Eric Wong <normalperson@...t.net>,
        Ondrej Zary <linux@...nbow-software.org>,
        Christophe TORDEUX <christophe@...deux.net>,
        Richard Pospesel <pospeselr@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: psmouse - disable automatic probing of BYD touchpads

On Saturday 12 November 2016 20:15:45 Dmitry Torokhov wrote:
> BYD automatic protocol detection is extremely unreliable and is often
> triggers false positives on regular mice, Sentelic touchpads, and
> other devices. BYD has several documents that have recommended
> detection sequence, but they conflict with each other and, as far as
> I can see, still would not produce unique enough output to reliably
> differentiate BYD from other PS/2 devices.
> 
> OEMs sourcing BYD devices also do not do us any favors by not
> supplying any reasonable DMI data and instead leaving turds like "To
> Be Filled By O.E.M." in place of vendor data, or "System Serial
> Number" as serial number.
...
> 	echo -n "byd" > /sys/bus/serio/devices/serio1/drvctl

I agree, if we cannot detect BYD devices correctly without breaking 
other non-BYD devices then detection must be done by user...

So you can add my Reviewed-by: Pali Rohár to this patch.

Anyway, BYD show Linux as supported OS for their devices. It is really 
rude from BYD that they show Linux as supported OS, but Linux driver is 
reverse-engineered by community and they do not want to cooperate and at 
least provide some useful documentation for detection...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)