linux-kernel - Re: [PATCH 03/11] mtd: nand: denali: remove bogus comment about interrupt handler setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <421bd929-f60f-78a9-d563-0b5972f48c0c@gmail.com>
Date:   Sat, 12 Nov 2016 22:29:32 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        David Woodhouse <David.Woodhouse@...el.com>,
        Richard Weinberger <richard@....at>,
        Jason Roberts <jason.e.roberts@...el.com>,
        linux-kernel@...r.kernel.org,
        Chuanxiao Dong <chuanxiao.dong@...el.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Dinh Nguyen <dinguyen@...era.com>,
        Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 03/11] mtd: nand: denali: remove bogus comment about
 interrupt handler setup

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The interrupt handler is setup in denali_init(), not in
> denali_drv_init().  This comment is false.
> 
> Such a comment adds no value, so just delete it instead of move.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
> 
>  drivers/mtd/nand/denali.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 51ddb84..d6f1b29 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1436,7 +1436,6 @@ static int denali_ooblayout_free(struct mtd_info *mtd, int section,
>  /* initialize driver data structures */
>  static void denali_drv_init(struct denali_nand_info *denali)
>  {
> -	/* setup interrupt handler */
>  	/*
>  	 * the completion object will be used to notify
>  	 * the callee that the interrupt is done
> 


-- 
Best regards,
Marek Vasut