linux-kernel - Re: [PATCH 01/11] mtd: nand: denali: remove unneeded <linux/slab.h> includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94e0b7c7-ab2e-c7a7-fcf3-a7c4bd123008@gmail.com>
Date:   Sat, 12 Nov 2016 22:28:53 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        David Woodhouse <David.Woodhouse@...el.com>,
        Richard Weinberger <richard@....at>,
        Jason Roberts <jason.e.roberts@...el.com>,
        linux-kernel@...r.kernel.org,
        Chuanxiao Dong <chuanxiao.dong@...el.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Dinh Nguyen <dinguyen@...era.com>,
        Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 01/11] mtd: nand: denali: remove unneeded <linux/slab.h>
 includes

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The driver calls devm_kzalloc()/devm_kfree() to allocate/free memory.
> They are declared in <linux/device.h>, not in <linux/slab.h>.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
> 
>  drivers/mtd/nand/denali.c     | 1 -
>  drivers/mtd/nand/denali_dt.c  | 1 -
>  drivers/mtd/nand/denali_pci.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 7e2c650..062d5b5 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -21,7 +21,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/wait.h>
>  #include <linux/mutex.h>
> -#include <linux/slab.h>
>  #include <linux/mtd/mtd.h>
>  #include <linux/module.h>
>  
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index f821dc1..5607fcd 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -21,7 +21,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
> -#include <linux/slab.h>
>  
>  #include "denali.h"
>  
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index de31514..ac84323 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -14,7 +14,6 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> -#include <linux/slab.h>
>  
>  #include "denali.h"
>  
> 


-- 
Best regards,
Marek Vasut