linux-kernel - Re: [git pull] vfs.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8ED81D5A-F56B-418A-99A9-2C197D9D2745@redhat.com>
Date:   Sat, 12 Nov 2016 11:36:49 +0800
From:   "Yan, Zheng" <zyan@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Ilya Dryomov <idryomov@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] vfs.git


> On 12 Nov 2016, at 01:25, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> On Thu, Nov 10, 2016 at 10:05 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>>        Christoph's and Jan's aio fixes, fixup for generic_file_splice_read
>> (removal of pointless detritus that actually breaks it when used for gfs2
>> ->splice_read()) and fixup for generic_file_read_iter() interaction with
>> ITER_PIPE destinations.
> 
> Hmm. I also just pulled the Ceph update that has commit 8a8d56176635
> ("ceph: use default file splice read callback"). I _think_ this splice
> fix makes that ceph change unnecessary. But testing is always good.

The commit is still needed. Al only fixes ITER_PIPE interaction with direct_IO. (it’s a no-op)
Cephfs case is special. Depending on what capabilities client has, client is allowed or
disallowed to read data from page cache. MDS changes client’s capabilities dynamically.
We don’t want to splice read fail when client is disallowed to get page from page cache.

Regards
Yan, Zheng 



> Ilya? Can you double-check the current -git tree (well, what I *will*
> push out soon after it has passed my build tests)?
> 
> Because I think Ceph can go back to using generic_file_splice_read again.
> 
>                      Linus