linux-kernel - Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2016 15:46:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Anton Leshchenko <antonl1911@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field
 definitions.

On Thu, Nov 10, 2016 at 10:17:23PM +0300, Dan Carpenter wrote:
> On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote:
> >  #define PIO2_CNTR_MODE0			0
> > -#define PIO2_CNTR_MODE1			(1 << 1)
> > -#define PIO2_CNTR_MODE2			(2 << 1)
> > -#define PIO2_CNTR_MODE3			(3 << 1)
> > -#define PIO2_CNTR_MODE4			(4 << 1)
> > -#define PIO2_CNTR_MODE5			(5 << 1)
> > +#define PIO2_CNTR_MODE1			BIT(1)
> > +#define PIO2_CNTR_MODE2			BIT(2)
> > +#define PIO2_CNTR_MODE3			(BIT(1) | BIT(2))
> > +#define PIO2_CNTR_MODE4			BIT(4)
> 
> This should be BIT(3)

Ugh, there were other parts wrong with this now that I look closer.
I've now reverted it.

thanks,

greg k-h