linux-kernel - Re: [PATCH 31/35] staging: lustre: obdclass: add export for lprocfs_stats_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161114145951.GA4245@kroah.com>
Date:   Mon, 14 Nov 2016 15:59:51 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     James Simmons <jsimmons@...radead.org>
Cc:     devel@...verdev.osuosl.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>,
        Chennaiah Palla <chennaiah.palla@...gate.com>
Subject: Re: [PATCH 31/35] staging: lustre: obdclass: add export for
 lprocfs_stats_alloc_one()

On Thu, Nov 10, 2016 at 12:31:01PM -0500, James Simmons wrote:
> From: Chennaiah Palla <chennaiah.palla@...gate.com>
> 
> When compiling the kernel without optimization, when using GCOV,
> the lprocfs_stats_alloc_one() symbol is not properly exported to
> other modules and causes the ptlrpc module to fail loading with
> an unknown symbol. Added EXPORT_SYMBOL(lprocfs_stats_alloc_one)
> so that this works properly.

No, let's fix this properly.  Please get rid of lprocfs_stats_lock(), or
if you _really_ need it, move it to a .c file.  Having it in a .h file
is just a mess, as this proves.

thanks,

greg k-h